done! #344
Merged
done! #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the static easyocr dependency from the pyproject.toml file and updates the easyocr loader to perform a runtime check for the package. Key changes include:
- Removal of the easyocr dependency from pyproject.toml.
- Removal of global imports for easyocr and json in document_loader_easy_ocr.py.
- Insertion of a try/except block to dynamically load easyocr and raise an informative error if it's not installed.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Removed the static dependency on easyocr to shift management to runtime checks. |
| extract_thinker/document_loader/document_loader_easy_ocr.py | Replaced global import with a try/except block to provide user guidance if easyocr is missing. |
Comments suppressed due to low confidence (1)
extract_thinker/document_loader/document_loader_easy_ocr.py:44
- The error message instructs users to 'pip install easyocr', but if the project is managed with Poetry, consider suggesting 'poetry add easyocr' to align with dependency management practices.
raise ImportError(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.